REF: tests.indexes.numeric.py #41192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 28, 2021
pandas/tests/indexes/test_numeric.py
Outdated
| _index_cls = Float64Index | ||
| _dtype = np.float64 | ||
|
|
||
| def create_index(self) -> Float64Index: |
There was a problem hiding this comment.
could make these into fixtures instead
jreback
added
Index
|
Ok, I have changed those to fixtures. |
jreback
approved these changes
Apr 30, 2021
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all index instantiation calls in
tests.indexes.numeric.pyuse the_holderclass variable instead of the actual index class. This will make it easier to extend the existing tests to tests for the newNumIndexin #41153.Also renames
_holderto_index_clsfor all oftests.indexes. I think this is a more descriptive name.